From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 May 2014 18:33:47 GMT
Subject: Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option
Message-ID: <xmqqvbt8jjlg.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140514182654.GA9218@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

>>> +		if (opt.ignore_case && !strcmp("less", pager))
>>> +			string_list_append(&path_list, "-i");
>>
>> I have a feeling that this goes against the recent trend of not
>> mucking with the expectation of the users on their pagers, if I
>> recall correctly the arguments for dropping S from the default given
>> to an unconfigured LESS environment variable.
>
> It's just missing an explanation.
> ...
> (That's -I, not -i, because it ought to work even when the pattern
> contains capital letters.)

Spot on.  The change, especially with "-I", makes sense.

Thanks.