Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 15, 2014, 17:46 UTC
- Message-ID
- <alpine.DEB.1.00.1405151944410.14982@s15462909.onlinehome-server.info>
- In-Reply-To
- <20140514190716.GA2715@sigill.intra.peff.net>
Hi Peff,
On Wed, 14 May 2014, Jeff King wrote:
Show 17 quoted lines
> On Wed, May 14, 2014 at 11:26:54AM -0700, Jonathan Nieder wrote: > > > "git grep" has other options that affect interpretation of the pattern > > which this patch does not help with: > > > > * -v / --ignore-match: probably should disable this feature of -O. > > * -E / --extended-regexp > > * -P / --perl-regexp > > * -F / --fixed-strings: ideally would auto-escape regex specials. > > * -e<pattern1> --or -e<pattern2> > > > > And git grep -Ovi has a similar bug, for which the fix is to add > > \c to the pattern instead of passing an -I option. > > We've already found the lines of interest to the user. It would be nice > if we could somehow point the pager at them by number, rather than > repeating the (slightly incompatible) search.
FWIW it is exactly that type of "I want your patch to do more than you do" type of comments that makes it impossible for myself to contribute patches anymore. It just does not fit inside my Git time budget anymore.
Besides, it breaks exactly the intended usage. My intent is not just to see the matching lines in the pager, but to be able to adjust the search pattern further if needed. Your suggestion completely breaks that usage.
Ciao, Johannes
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.