Re: [PATCH v4] refs.c: add a function to append a reflog entry to a fd

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2014, 22:29 UTC
Message-ID: <xmqqvbm91p6m.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20141120221110.GM6527@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 10 quoted lines

> Stefan Beller wrote:
>
>> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
> [...]
>>  refs.c | 48 ++++++++++++++++++++++++++++++------------------
>>  1 file changed, 30 insertions(+), 18 deletions(-)
>
> The --patience diff makes review of this version very simple.

I guess it depends on what the reader is focusing on, but at least to me I found the default or histogram much easier to see what is going on. It could be due to my use of large -U<context> value, too.

> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.