git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] refs.c: add a function to append a reflog entry to a fd

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 20, 2014, 22:05 UTC
Message-ID
<20141120220558.GL6527@google.com>
In-Reply-To
<20141120215800.GA22370@google.com>
Stefan Beller wrote:
> From 4bec12b878ca02a1e80af3c265e7e7ab52ba17ce Mon Sep 17 00:00:00 2001

The above line causes "git am" to be unable to parse the message downloaded as an mbox, if I remember correctly.

[...]
>  * break lines of commit message again to appease the taste of Jonathan ;)

I hope it's not just to appease me. If the rationale behind a comment I make isn't clear, always feel free to ask.

In this case, it is about readability. It's perhaps irrational, but I find text much more readable and the intent to be clearer when paragraphs are wrapped to a consistent width instead of lines breaking at arbitrary points.

Perhaps a nice way to make this a non-issue in the future would be an option to "git am" to rewrap.

Previous: Stefan BellerNext: Junio C Hamano
Message 13 of 18 in “refs.c: add a function to append a reflog entry to a fd”
  1. refs.c: add a function to append a reflog entry to a fdStefan Beller, Nov 20, 2014
  2. Junio C HamanoNov 20, 2014
  3. Junio C HamanoNov 20, 2014
  4. refs.c: add a function to append a reflog entry to a fdStefan Beller, Nov 20, 2014
  5. Jonathan NiederNov 20, 2014
  6. Junio C HamanoNov 20, 2014
  7. refs.c: add a function to append a reflog entry to a fdStefan Beller, Nov 20, 2014
  8. Jonathan NiederNov 20, 2014
  9. Stefan BellerNov 20, 2014
  10. Jonathan NiederNov 20, 2014
  11. Junio C HamanoNov 20, 2014
  12. Stefan BellerNov 20, 2014
  13. Jonathan NiederNov 20, 2014
  14. Junio C HamanoNov 20, 2014
  15. refs.c: add a function to append a reflog entry to a fdStefan Beller, Nov 20, 2014
  16. Jonathan NiederNov 20, 2014
  17. Junio C HamanoNov 20, 2014
  18. Jonathan NiederNov 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.