git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 17, 2015, 20:15 UTC
Message-ID
<xmqqvbem5bx9.fsf@gitster.dls.corp.google.com>
In-Reply-To
<5581D099.7090200@bbn.com>
Richard Hansen <rhansen@bbn.com> writes:
Show 11 quoted lines
> We could test if the variable is set first (test -n "${foo+set}"), at
> the cost of a bit more complexity.
>
>> I do not mind it so much as you have
>> it, but it does mean adding a new field needs to update two spots.
>
> I also don't like the duplicate list of color types, and I considered
> doing something similar to what you suggested, but I decided against it.
> I'm a bit worried about bizarre syntax errors or code execution if
> say_color() is used improperly.  ('eval' with uncontrolled variables
> makes me nervous.)

I originally had the same reaction to your use of `eval` (with or without being guarded by the case to limit to known 5 ones). But the uncontrolled-ness of this use of eval is to the same degree of uncontrolled-ness of any test_expect_{success,failure} scriptlet, so...

I like this "save to variables instead of using tput" approach very much either way. Well done.

Thanks.
Previous: Richard HansenNext: Richard Hansen
Message 6 of 13 in “redo fix for test-lib.sh color support”
  1. 0/2 redo fix for test-lib.sh color supportRichard Hansen, Jun 17, 2015
  2. 1/2 Revert "test-lib.sh: do tests for color support after changing HOME"Richard Hansen, Jun 17, 2015
  3. 2/2 test-lib.sh: fix color support when tput needs ~/.terminfoRichard Hansen, Jun 17, 2015
  4. Jeff KingJun 17, 2015
  5. Richard HansenJun 17, 2015
  6. Junio C HamanoJun 17, 2015
  7. 0/2 redo fix for test-lib.sh color supportRichard Hansen, Jun 17, 2015
  8. 1/2 Revert "test-lib.sh: do tests for color support after changing HOME"Richard Hansen, Jun 17, 2015
  9. 2/2 test-lib.sh: fix color support when tput needs ~/.terminfoRichard Hansen, Jun 17, 2015
  10. Jeff KingJun 17, 2015
  11. Junio C HamanoJun 17, 2015
  12. Jeff KingJun 17, 2015
  13. Jeff KingJun 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.