git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo

From
Jeff King <peff@peff.net>
Date
Jun 17, 2015, 22:26 UTC
Message-ID
<20150617222602.GA31735@peff.net>
In-Reply-To
<xmqq7fr255ze.fsf@gitster.dls.corp.google.com>
On Wed, Jun 17, 2015 at 03:23:49PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > On Wed, Jun 17, 2015 at 05:11:21PM -0400, Richard Hansen wrote:
> >
> >> +		test -z "$1" && test -n "$quiet" && return
> >> +		eval "say_color_color=\$say_color_$1"
> >
> > Thanks, this looks much simpler.
> >
> > In the non-quiet case, you will eval $say_color_, even though we know it
> > to be bogus.
> 
> Yeah, but there is this gem in this patch:
> 
> +	...
> +	say_color_info=$(tput setaf 6) # cyan
> +	say_color_reset=$(tput sgr0)
> +	say_color_="" # no formatting for normal text

Oh, sorry, I was so focused on the later part that I totally missed that. That is rather elegant, and nicer than what I wrote.

-Peff
Previous: Junio C HamanoNext: Jeff King
Message 12 of 13 in “redo fix for test-lib.sh color support”
  1. 0/2 redo fix for test-lib.sh color supportRichard Hansen, Jun 17, 2015
  2. 1/2 Revert "test-lib.sh: do tests for color support after changing HOME"Richard Hansen, Jun 17, 2015
  3. 2/2 test-lib.sh: fix color support when tput needs ~/.terminfoRichard Hansen, Jun 17, 2015
  4. Jeff KingJun 17, 2015
  5. Richard HansenJun 17, 2015
  6. Junio C HamanoJun 17, 2015
  7. 0/2 redo fix for test-lib.sh color supportRichard Hansen, Jun 17, 2015
  8. 1/2 Revert "test-lib.sh: do tests for color support after changing HOME"Richard Hansen, Jun 17, 2015
  9. 2/2 test-lib.sh: fix color support when tput needs ~/.terminfoRichard Hansen, Jun 17, 2015
  10. Jeff KingJun 17, 2015
  11. Junio C HamanoJun 17, 2015
  12. Jeff KingJun 17, 2015
  13. Jeff KingJun 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.