git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo

From
Jeff King <peff@peff.net>
Date
Jun 17, 2015, 20:25 UTC
Message-ID
<20150617202507.GA25234@peff.net>
In-Reply-To
<5581D099.7090200@bbn.com>
On Wed, Jun 17, 2015 at 03:55:05PM -0400, Richard Hansen wrote:
Show 8 quoted lines
> > I do not mind it so much as you have
> > it, but it does mean adding a new field needs to update two spots.
> 
> I also don't like the duplicate list of color types, and I considered
> doing something similar to what you suggested, but I decided against it.
>  I'm a bit worried about bizarre syntax errors or code execution if
> say_color() is used improperly.  ('eval' with uncontrolled variables
> makes me nervous.)

As Junio pointed out, I think all bets are off in the test scripts. They are running tons of arbitrary code. :)

But for the record, I am fine with your patch as-is. Thanks for looking into it.

-Peff
Previous: Jeff King
Message 13 of 13 in “redo fix for test-lib.sh color support”
  1. 0/2 redo fix for test-lib.sh color supportRichard Hansen, Jun 17, 2015
  2. 1/2 Revert "test-lib.sh: do tests for color support after changing HOME"Richard Hansen, Jun 17, 2015
  3. 2/2 test-lib.sh: fix color support when tput needs ~/.terminfoRichard Hansen, Jun 17, 2015
  4. Jeff KingJun 17, 2015
  5. Richard HansenJun 17, 2015
  6. Junio C HamanoJun 17, 2015
  7. 0/2 redo fix for test-lib.sh color supportRichard Hansen, Jun 17, 2015
  8. 1/2 Revert "test-lib.sh: do tests for color support after changing HOME"Richard Hansen, Jun 17, 2015
  9. 2/2 test-lib.sh: fix color support when tput needs ~/.terminfoRichard Hansen, Jun 17, 2015
  10. Jeff KingJun 17, 2015
  11. Junio C HamanoJun 17, 2015
  12. Jeff KingJun 17, 2015
  13. Jeff KingJun 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.