Re: [PATCH] t7300: mark test with SANITY

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2016, 19:09 UTC
Message-ID: <xmqqvb2vm00a.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160503190417.GD30530@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Tue, May 03, 2016 at 11:54:32AM -0700, Stefan Beller wrote:
>
>> As the test runs `chmod 0` on a file, we don't want to run that test
>> as root.
>
> This somehow misses the root (no pun intended) of the issue, to me.
> Perhaps:
>
>   We `chmod 0` a file and test a case where git is unable to read it.
>   If the test is run as root, the permissions are ignored, and our
>   simulated read failure does not happen.
>
> The patch itself looks obviously correct. :)
>
> -Peff

Yup, I had exactly the same reaction.

Thanks.