Re: [PATCH] t7300: mark test with SANITY

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2016, 21:19 UTC
Message-ID: <xmqqk2jalu03.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160503211528.GA32737@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> Maybe. I admit to not really using the Travis tests myself, as they are
> way too slow and cumbersome to debug compared to just running "make
> test".  The primary value to me of centralized CI is:
>
>   1. _If_ people are looking at PRs on GitHub, the test status is shown
>      right there in the PR, without a reviewer having to wonder whether
>      the submitter ran "make test". But since I don't ever look at PRs
>      for Git, that's not helpful.

What I was hoping was that bots like SubmitGit could look at that status.

Show 5 quoted lines

>   2. Quicker testing on a variety of platforms that I don't have.
>
>      ... I think
>      there was some discussion in the 0day thread elsewhere on the list,
>      but I didn't follow it too closely.

Yes, I'd love to see it happen some day.

Show 5 quoted lines

> Anyway, back to the original question. I do think "test as root" can be
> considered another platform, which makes it a good match for CI. But at
> the same time, I don't know that it has ever surfaced an actual bug in
> _Git_, and not just the test suite. So seeing those bugs quickly is a
> lot less interesting.

True.