Re: [PATCH] t7300: mark test with SANITY
- From
Jeff King <peff@peff.net>
- Date
- May 3, 2016, 21:35 UTC
- Message-ID
- <20160503213556.GA25133@sigill.intra.peff.net>
- In-Reply-To
- <xmqqk2jalu03.fsf@gitster.mtv.corp.google.com>
On Tue, May 03, 2016 at 02:19:24PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> Jeff King <peff@peff.net> writes: > > > Maybe. I admit to not really using the Travis tests myself, as they are > > way too slow and cumbersome to debug compared to just running "make > > test". The primary value to me of centralized CI is: > > > > 1. _If_ people are looking at PRs on GitHub, the test status is shown > > right there in the PR, without a reviewer having to wonder whether > > the submitter ran "make test". But since I don't ever look at PRs > > for Git, that's not helpful. > > What I was hoping was that bots like SubmitGit could look at that > status.
Yeah, I think that would be pretty trivial to do. It's already interacting with GitHub's API, and I think there's a simple call to query the test status (so it wouldn't even require SubmitGit talking to Travis directly).
I don't think that really solves the problem overall, though. SubmitGit is still a minority of patch submissions (and I wouldn't expect that to change, but maybe I'm just a curmudgeon).
-Peff