Re: [ANNOUNCE] Git v2.11.0-rc0

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2016, 21:45 UTC
Message-ID: <xmqqvaw6nac0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqzilinanp.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> And here is _with_ renaming.  I think "compaction heuristics" is a
> much better phrase to call "heuristics used during the diff hunk
> compaction process" without specifying how that heuristics work
> (like taking hints in the indentation levels).  If we are to retire
> one while keeping the other, compaction-heuristics should be the
> name we give and keep for the surviving one.
>
> I have not much confidence in the conversion result, though.

I'll queue it on 'pu' for now, before I go offline for a few days, with the following log message:

    diff: retire the original experimental "compaction" heuristics
    
    This retires the experimental "compaction" heuristics but with a
    twist.  It removes the mention of "indent" heuristics, which was a
    competing experiment, from everywhere, guts the core logic of the
    original "compaction" heuristics out and replaces it with the logic
    used by the "indent" heuristics.
    
    The externally visible effect of this change is that people who have
    been experimenting by setting diff.compactionHeuristic configuration
    or giving the command line option --compaction-heuristic will start
    getting the behaviour based on the improved heuristics that used to
    be called "indent" heuristics.
    
    Suggested-by: Jeff King <peff@peff.net>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>