Re: [PATCHv5 4/5] worktree: get worktrees from submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 7, 2016, 22:45 UTC
Message-ID: <xmqqvauvuzna.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161207210157.18932-5-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> +	submodule_common_dir = strbuf_detach(&sb, NULL);
> +	ret = get_worktrees_internal(submodule_common_dir, flags);
> +
> +	free(submodule_gitdir);

This sequence felt somewhat unusual. I would have written this without an extra variable, i.e.

	ret = get_worktrees_internal(sb.buf, flags);
	strbuf_release(&sb);

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.