Re: [PATCHv5 4/5] worktree: get worktrees from submodules

From: Stefan Beller <sbeller@google.com>
Date: Dec 7, 2016, 22:51 UTC
Message-ID: <CAGZ79kZiS9dx6QUOcFYh8sSNoVsrv2eNLXJd6X54UekzUiC8VQ@mail.gmail.com>
In-Reply-To: <xmqqvauvuzna.fsf@gitster.mtv.corp.google.com>

On Wed, Dec 7, 2016 at 2:45 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> +     submodule_common_dir = strbuf_detach(&sb, NULL);
>> +     ret = get_worktrees_internal(submodule_common_dir, flags);
>> +
>> +     free(submodule_gitdir);
>
> This sequence felt somewhat unusual.  I would have written this
> without an extra variable, i.e.
>
>         ret = get_worktrees_internal(sb.buf, flags);
>         strbuf_release(&sb);

Yours is cleaner; I don't remember what I was thinking.

Feel free to squash it in; in case a resend is needed I will do that.

Thanks, Stefan