From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 07 Dec 2016 22:45:29 GMT
Subject: Re: [PATCHv5 4/5] worktree: get worktrees from submodules
Message-ID: <xmqqvauvuzna.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161207210157.18932-5-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> +	submodule_common_dir = strbuf_detach(&sb, NULL);
> +	ret = get_worktrees_internal(submodule_common_dir, flags);
> +
> +	free(submodule_gitdir);

This sequence felt somewhat unusual.  I would have written this
without an extra variable, i.e.

	ret = get_worktrees_internal(sb.buf, flags);
	strbuf_release(&sb);