Re: [PATCH v3 06/21] t1700: add tests for core.splitIndex

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 27, 2016, 19:04 UTC
Message-ID: <xmqqvau59ocy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161226102222.17150-7-chriscool@tuxfamily.org>

Christian Couder <christian.couder@gmail.com> writes:

Show 11 quoted lines

> +test_expect_success 'set core.splitIndex config variable to true' '
> +	git config core.splitIndex true &&
> +	: >three &&
> +	git update-index --add three &&
> +	git ls-files --stage >ls-files.actual &&
> +	cat >ls-files.expect <<EOF &&
> +100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0	one
> +100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0	three
> +100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0	two
> +EOF
> +	test_cmp ls-files.expect ls-files.actual &&

It does not add much value to follow the "existing" outdated style like this when you are only adding new tests. Write these like

        cat >ls-files.expect <<-\EOF &&
	100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0	one
	100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0	three
	100644 e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 0	two
	EOF

which would give incentive to others (or yourself) to update the style of the existing mess ;-).