git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 14/21] read-cache: touch shared index files when used

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 23, 2017, 18:53 UTC
Message-ID
<xmqqefztsj4c.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAP8UFD2LWGtNtdhtQTZXqsACBvK=jD25vt8M4HzBRBVS1sJ+=Q@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 16 quoted lines
> Also in general the split-index mode is useful when you often write
> new indexes, and in this case shared index files that are used will
> often be freshened, so the risk of deleting interesting shared index
> files should be low.
> ...
>> Not that I think freshening would actually fail in a repository
>> where you can actually write into to update the index or its refs to
>> make a difference (iow, even if we make it die() loudly when shared
>> index cannot be "touched" because we are paranoid, no real life
>> usage will trigger that die(), and if a repository does trigger the
>> die(), I think you would really want to know about it).
>
> As I wrote above, I think if we can actually write the shared index
> file but its freshening fails, it probably means that the shared index
> file has been removed behind us, and this case is equivalent as when
> loose files have been removed behind us.

OK, so it is unlikely to happen, and when it happens it leads to a catastrophic failure---do we just ignore or do we report an error?

Previous: Christian CouderNext: Christian Couder
Message 36 of 56 in “Add configuration options for split-index”
  1. 00/21 Add configuration options for split-indexChristian Couder, Dec 26, 2016
  2. 01/21 config: mark an error message up for translationChristian Couder, Dec 26, 2016
  3. 02/21 config: add git_config_get_split_index()Christian Couder, Dec 26, 2016
  4. 03/21 split-index: add {add,remove}_split_index() functionsChristian Couder, Dec 26, 2016
  5. 04/21 read-cache: add and then use tweak_split_index()Christian Couder, Dec 26, 2016
  6. 09/21 config: add git_config_get_max_percent_split_change()Christian Couder, Dec 26, 2016
  7. 10/21 read-cache: regenerate shared index if necessaryChristian Couder, Dec 26, 2016
  8. Junio C HamanoDec 27, 2016
  9. Christian CouderJan 2, 2017
  10. 05/21 update-index: warn in case of split-index incoherencyChristian Couder, Dec 26, 2016
  11. 11/21 t1700: add tests for splitIndex.maxPercentChangeChristian Couder, Dec 26, 2016
  12. 15/21 config: add git_config_get_expiry() from gc.cChristian Couder, Dec 26, 2016
  13. 12/21 Documentation/config: add splitIndex.maxPercentChangeChristian Couder, Dec 26, 2016
  14. Junio C HamanoDec 27, 2016
  15. Christian CouderJan 2, 2017
  16. 19/21 read-cache: use freshen_shared_index() in read_index_from()Christian Couder, Dec 26, 2016
  17. 20/21 Documentation/config: add splitIndex.sharedIndexExpireChristian Couder, Dec 26, 2016
  18. Junio C HamanoDec 27, 2016
  19. Christian CouderJan 2, 2017
  20. 17/21 t1700: test shared index file expirationChristian Couder, Dec 26, 2016
  21. 21/21 Documentation/git-update-index: explain splitIndex.*Christian Couder, Dec 26, 2016
  22. Junio C HamanoDec 27, 2016
  23. Christian CouderJan 2, 2017
  24. 18/21 read-cache: refactor read_index_from()Christian Couder, Dec 26, 2016
  25. 16/21 read-cache: unlink old sharedindex filesChristian Couder, Dec 26, 2016
  26. 14/21 read-cache: touch shared index files when usedChristian Couder, Dec 26, 2016
  27. Junio C HamanoDec 27, 2016
  28. Christian CouderJan 2, 2017
  29. Junio C HamanoJan 7, 2017
  30. Duy NguyenJan 9, 2017
  31. Junio C HamanoJan 9, 2017
  32. Duy NguyenJan 19, 2017
  33. Junio C HamanoJan 19, 2017
  34. Duy NguyenJan 20, 2017
  35. Christian CouderJan 23, 2017
  36. Junio C HamanoJan 23, 2017
  37. Christian CouderJan 25, 2017
  38. Junio C HamanoJan 25, 2017
  39. Christian CouderJan 31, 2017
  40. Junio C HamanoJan 31, 2017
  41. Junio C HamanoJan 31, 2017
  42. 13/21 sha1_file: make check_and_freshen_file() non staticChristian Couder, Dec 26, 2016
  43. Junio C HamanoDec 27, 2016
  44. 07/21 Documentation/config: add information for core.splitIndexChristian Couder, Dec 26, 2016
  45. 08/21 Documentation/git-update-index: talk about core.splitIndex config varChristian Couder, Dec 26, 2016
  46. Junio C HamanoDec 27, 2016
  47. Christian CouderJan 2, 2017
  48. Junio C HamanoJan 7, 2017
  49. Duy NguyenJan 9, 2017
  50. Christian CouderJan 23, 2017
  51. Junio C HamanoJan 23, 2017
  52. 06/21 t1700: add tests for core.splitIndexChristian Couder, Dec 26, 2016
  53. Junio C HamanoDec 27, 2016
  54. Christian CouderJan 2, 2017
  55. Junio C HamanoJan 3, 2017
  56. Christian CouderDec 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.