Re: [PATCH 1/8] tag: Remove a TODO item from the test suite
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 18, 2017, 18:14 UTC
- Message-ID
- <xmqqvar6310x.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170318103256.27141-2-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 8 quoted lines
> Change the test for "git tag -l" to not have an associated TODO
> comment saying that it should return non-zero if there's no tags.
>
> This was added in commit ef5a6fb597 ("Add test-script for git-tag",
> 2007-06-28) when the tests for "tag" were initially added, but at this
> point changing this would be inconsistent with how "git tag" is a
> synonym for "git tag -l", and would needlessly break external code
> that relies on this porcelain command.Makes sense.
I'll retitle s/Remove/remove/ so that "git shortlog --no-merges" would look more consistent, though.
Thanks.