Re: [PATCH 3/8] tag: Change misleading --list <pattern> documentation

From: Jeff King <peff@peff.net>
Date: Mar 20, 2017, 03:44 UTC
Message-ID: <20170320034443.wq2uf4yabsxh2nji@sigill.intra.peff.net>
In-Reply-To: <xmqqmvci2zoc.fsf@gitster.mtv.corp.google.com>

On Sat, Mar 18, 2017 at 11:43:47AM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> > +test_expect_success 'Multiple -l or --list options are equivalent to one -l option' '
> > +	git tag -l -l >actual &&
> > +	test_cmp expect actual &&
> > +	git tag --list --list >actual &&
> > +	test_cmp expect actual &&
> > +	git tag --list -l --list >actual &&
> > +	test_cmp expect actual
> > +'
> 
> OK.  I do not care too deeply about this one, but somebody may want
> to tighten up the command line parsing to detect conflicting or
> duplicated cmdmode as an error in the future, and at that time this
> will require updating.  I am not sure if we want to promise that
> giving multiple -l will keep working.

I think it's expected to work under the usual last-one-wins option parsing. A more subtle case is that:

  git tag -l -d foo

would override "-l" with "-d". That's reasonable under the same rule as long as the user knows that the two are mode-selectors. I don't think we make that explicit in the documentation, though, so perhaps it isn't something users should rely on.

-Peff