git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 1/6] t0021: keep filter log files on comparison

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 26, 2017, 17:31 UTC
Message-ID
<xmqqvani64g0.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<79C07E47-251D-4869-8EEA-11A9E336ABF3@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 15 quoted lines
>> It would become a problem _if_ we want future users of this helper
>> to reuse the same expect (or actual) multiple times and start from
>> an unmodified one.  There may be some other reason why you do not
>> want the comparison to smudge these files.  Please state what that
>> reason is before saying "fix this".
>
> Understood. How about this?
>
>     The filter log files are modified on comparison. That might be 
>     unexpected by the caller. It would be even undesirable if the caller 
>     wants to reuse the original log files.
>
>     Address these issues by using temp files for modifications. This is 
>     useful for the subsequent patch 'convert: add "status=delayed" to 
>     filter process protocol'.
The updated one is much more understandable.  Thanks.
> If this is OK, then do you want me to resend the series or can you fix it
> in place?

In general, I am OK running "rebase -i" to polish the log message unless there are other changes to the patches planned.

Previous: Lars SchneiderNext: Lars Schneider
Message 5 of 24 in “convert: add "status=delayed" to filter process protocol”
  1. 0/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 25, 2017
  2. 1/6 t0021: keep filter log files on comparisonLars Schneider, Jun 25, 2017
  3. Junio C HamanoJun 25, 2017
  4. Lars SchneiderJun 26, 2017
  5. Junio C HamanoJun 26, 2017
  6. 2/6 t0021: make debug log file name configurableLars Schneider, Jun 25, 2017
  7. Junio C HamanoJun 25, 2017
  8. 3/6 t0021: write "OUT" only on successLars Schneider, Jun 25, 2017
  9. Junio C HamanoJun 25, 2017
  10. Lars SchneiderJun 26, 2017
  11. Junio C HamanoJun 26, 2017
  12. Lars SchneiderJun 26, 2017
  13. 6/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 25, 2017
  14. Junio C HamanoJun 26, 2017
  15. Lars SchneiderJun 26, 2017
  16. Junio C HamanoJun 26, 2017
  17. Junio C HamanoJun 26, 2017
  18. Lars SchneiderJun 27, 2017
  19. 4/6 convert: put the flags field before the flag itself for consistent styleLars Schneider, Jun 25, 2017
  20. Junio C HamanoJun 25, 2017
  21. 5/6 convert: move multiple file filter error handling to separate functionLars Schneider, Jun 25, 2017
  22. Junio C HamanoJun 26, 2017
  23. Stefan BellerJun 27, 2017
  24. Junio C HamanoJun 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.