Re: [PATCH v6 3/6] t0021: write "OUT" only on success

From: Lars Schneider <larsxschneider@gmail.com>
Date: Jun 26, 2017, 09:26 UTC
Message-ID: <0FC46284-650F-411D-845F-0DF4F32071FF@gmail.com>
In-Reply-To: <xmqqlgof7lw7.fsf@gitster.mtv.corp.google.com>

Show 11 quoted lines

> On 26 Jun 2017, at 00:17, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>> "rot13-filter.pl" used to write "OUT <size>" to the debug log even in case of
>> an abort or error. Fix this by writing "OUT <size>" to the debug log only in
>> the successful case if output is actually written.
> 
> Again, use of "Fix this" without clarifying what the problem is.  Is
> this change needed because the size may not be known when the new
> filter protocol is in use, or something?

How about this?

    "rot13-filter.pl" always writes "OUT <size>" to the debug log at the end
    of an interaction.

    This works without issues for the existing cases "abort", "error", and 
    "success". In a subsequent patch 'convert: add "status=delayed" to 
    filter process protocol' we will add a new case "delayed". In that case 
    we do not send the data right away and it would be wrong/misleading to
    the reader if we would write "OUT <size>" to the debug log.

    Address this issue by writing "OUT <size>" to the debug log only if 
    output is actually written in the successful case.

- Lars