git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 3/6] t0021: write "OUT" only on success

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 25, 2017, 22:17 UTC
Message-ID
<xmqqlgof7lw7.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170625182125.6741-4-larsxschneider@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
> "rot13-filter.pl" used to write "OUT <size>" to the debug log even in case of
> an abort or error. Fix this by writing "OUT <size>" to the debug log only in
> the successful case if output is actually written.

Again, use of "Fix this" without clarifying what the problem is. Is this change needed because the size may not be known when the new filter protocol is in use, or something?

`
Previous: Lars SchneiderNext: Lars Schneider
Message 9 of 24 in “convert: add "status=delayed" to filter process protocol”
  1. 0/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 25, 2017
  2. 1/6 t0021: keep filter log files on comparisonLars Schneider, Jun 25, 2017
  3. Junio C HamanoJun 25, 2017
  4. Lars SchneiderJun 26, 2017
  5. Junio C HamanoJun 26, 2017
  6. 2/6 t0021: make debug log file name configurableLars Schneider, Jun 25, 2017
  7. Junio C HamanoJun 25, 2017
  8. 3/6 t0021: write "OUT" only on successLars Schneider, Jun 25, 2017
  9. Junio C HamanoJun 25, 2017
  10. Lars SchneiderJun 26, 2017
  11. Junio C HamanoJun 26, 2017
  12. Lars SchneiderJun 26, 2017
  13. 6/6 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 25, 2017
  14. Junio C HamanoJun 26, 2017
  15. Lars SchneiderJun 26, 2017
  16. Junio C HamanoJun 26, 2017
  17. Junio C HamanoJun 26, 2017
  18. Lars SchneiderJun 27, 2017
  19. 4/6 convert: put the flags field before the flag itself for consistent styleLars Schneider, Jun 25, 2017
  20. Junio C HamanoJun 25, 2017
  21. 5/6 convert: move multiple file filter error handling to separate functionLars Schneider, Jun 25, 2017
  22. Junio C HamanoJun 26, 2017
  23. Stefan BellerJun 27, 2017
  24. Junio C HamanoJun 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.