git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] progress: print progress output for all operations taking longer than 2s

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 4, 2017, 21:38 UTC
Message-ID
<xmqqvahmkwbi.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171204213350.GA21552@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> So the minimal fix is actually:
>
> diff --git a/progress.c b/progress.c
> index 289678d43d..b774cb1cd1 100644
> --- a/progress.c
> +++ b/progress.c
> @@ -229,7 +229,7 @@ static struct progress *start_progress_delay(const char *title, unsigned total,
>  
>  struct progress *start_delayed_progress(const char *title, unsigned total)
>  {
> -	return start_progress_delay(title, total, 0, 2);
> +	return start_progress_delay(title, total, 100, 2);
>  }

That makes a lot more sense to me (at least from a cursory comparison between the two approaches).

Previous: Jeff KingNext: Jeff King
Message 3 of 11 in “progress: print progress output for all operations taking longer than 2s”
  1. progress: print progress output for all operations taking longer than 2slars.schneider@autodesk.com, Dec 4, 2017
  2. Jeff KingDec 4, 2017
  3. Junio C HamanoDec 4, 2017
  4. 0/2 fix v2.15 progress regressionJeff King, Dec 4, 2017
  5. 1/2 progress: set default delay threshold to 100%, not 0%Jeff King, Dec 4, 2017
  6. 2/2 progress: drop delay-threshold codeJeff King, Dec 4, 2017
  7. Lars SchneiderDec 5, 2017
  8. Ævar Arnfjörð BjarmasonDec 5, 2017
  9. Lars SchneiderDec 5, 2017
  10. Junio C HamanoDec 4, 2017
  11. Junio C HamanoDec 4, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.