Re: [PATCH v1] progress: print progress output for all operations taking longer than 2s
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 4, 2017, 21:38 UTC
- Message-ID
- <xmqqvahmkwbi.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20171204213350.GA21552@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> So the minimal fix is actually:
>
> diff --git a/progress.c b/progress.c
> index 289678d43d..b774cb1cd1 100644
> --- a/progress.c
> +++ b/progress.c
> @@ -229,7 +229,7 @@ static struct progress *start_progress_delay(const char *title, unsigned total,
>
> struct progress *start_delayed_progress(const char *title, unsigned total)
> {
> - return start_progress_delay(title, total, 0, 2);
> + return start_progress_delay(title, total, 100, 2);
> }That makes a lot more sense to me (at least from a cursory comparison between the two approaches).