Re: [PATCH 2/2] progress: drop delay-threshold code
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Dec 5, 2017, 11:10 UTC
- Message-ID
- <CACBZZX63ZhOHXmgerpJHc+ri_-w=QUyOQ7feWHxyDwPhN8hnDg@mail.gmail.com>
- In-Reply-To
- <BBE0F8C1-2B9E-42B6-AE47-90C8A62A4F84@gmail.com>
On Tue, Dec 5, 2017 at 11:37 AM, Lars Schneider <larsxschneider@gmail.com> wrote:
Show 34 quoted lines
>
>> On 04 Dec 2017, at 23:07, Jeff King <peff@peff.net> wrote:
>>
>> From: Lars Schneider <larsxschneider@gmail.com>
>>
>> Since 180a9f2268 (provide a facility for "delayed" progress
>> reporting, 2007-04-20), the progress code has allowed
>> callers to skip showing progress if they have reached a
>> percentage-threshold of the total work before the delay
>> period passes.
>>
>> But since 8aade107dd (progress: simplify "delayed" progress
>> API, 2017-08-19), that parameter is not available to outside
>> callers (we always passed zero after that commit, though
>> that was corrected in the previous commit to "100%").
>>
>> Let's drop the threshold code, which never triggers in
>> any meaningful way.
>>
>> Signed-off-by: Jeff King <peff@peff.net>
>> ---
>> I tweaked your patch slightly to clean up the now-simplified
>> conditional.
>
> Your first patch ("progress: set default delay threshold to 100%, not 0%")
> as well as the modifications to this one look good to me. Feel free
> to add my "Signed-off-by: Lars Schneider <larsxschneider@gmail.com>".
>
> Thanks,
> Lars
>
>
> PS: How do you generate the commit references "hash (first line, date)"?
> Git log pretty print?$ git grep -A5 'Copy commit summary' Documentation/SubmittingPatches Documentation/SubmittingPatches:151:The "Copy commit summary" command of gitk can be used to obtain this Documentation/SubmittingPatches-152-format, or this invocation of `git show`: Documentation/SubmittingPatches-153- Documentation/SubmittingPatches-154-.... Documentation/SubmittingPatches-155- git show -s --date=short --pretty='format:%h ("%s", %ad)' <commit>