Re: [PATCH 2/2] progress: drop delay-threshold code

From: Lars Schneider <larsxschneider@gmail.com>
Date: Dec 5, 2017, 10:37 UTC
Message-ID: <BBE0F8C1-2B9E-42B6-AE47-90C8A62A4F84@gmail.com>
In-Reply-To: <20171204220700.GB18828@sigill.intra.peff.net>

Show 22 quoted lines

> On 04 Dec 2017, at 23:07, Jeff King <peff@peff.net> wrote:
> 
> From: Lars Schneider <larsxschneider@gmail.com>
> 
> Since 180a9f2268 (provide a facility for "delayed" progress
> reporting, 2007-04-20), the progress code has allowed
> callers to skip showing progress if they have reached a
> percentage-threshold of the total work before the delay
> period passes.
> 
> But since 8aade107dd (progress: simplify "delayed" progress
> API, 2017-08-19), that parameter is not available to outside
> callers (we always passed zero after that commit, though
> that was corrected in the previous commit to "100%").
> 
> Let's drop the threshold code, which never triggers in
> any meaningful way.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I tweaked your patch slightly to clean up the now-simplified
> conditional.

Your first patch ("progress: set default delay threshold to 100%, not 0%") as well as the modifications to this one look good to me. Feel free to add my "Signed-off-by: Lars Schneider <larsxschneider@gmail.com>".

Thanks, Lars

PS: How do you generate the commit references "hash (first line, date)"?
Git log pretty print?