Re: [PATCH] travis-ci: build Git during the 'script' phase
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 8, 2018, 22:07 UTC
- Message-ID
- <xmqqvagc6m42.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20180108172214.23615-1-szeder.dev@gmail.com>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 9 quoted lines
> The reason why Travis CI does it this way and why it's a better > approach than ours lies in how unsuccessful build jobs are > categorized. ... > ... > This makes it easier, both for humans looking at the Travis CI web > interface and for automated tools querying the Travis CI API,... > ... > A verbose commit message for such a change... but I don't know why we > started with building Git in the 'before_script' phase.
Thanks for writing it up clearly. TBH, I didn't even realize that there were meaningful distinctions between the two cases after seeing that sometimes our tests were failing and sometimes erroring ;-)
> Should go on top of 'sg/travis-check-untracked' in 'next'.