Re: [PATCH] travis-ci: build Git during the 'script' phase

From: Jeff King <peff@peff.net>
Date: Jan 14, 2018, 11:07 UTC
Message-ID: <20180114110734.GA13643@sigill.intra.peff.net>
In-Reply-To: <CAM0VKj=QrDr9671uMGKSSZUczB-Soc5mmoijiBsx8t_WkQa6+w@mail.gmail.com>

On Sun, Jan 14, 2018 at 11:37:07AM +0100, SZEDER Gábor wrote:

Show 12 quoted lines

> > +fold_cmd () {
> > +       local name=$1; shift
> > +       fold "$name"
> > +       "$@"
> > +       local ret=$?
> > +       unfold "$name"
> > +       return $ret
> > +}
> 
> We don't have to fiddle with the return value, because we run (almost
> all of) our build scripts with 'set -e', i.e. if the command fails then
> the script will exit immediately.

Yeah, that's probably enough for our simple scripts, though I have been bit by "set -e" vagaries before (e.g., calling the function inside a conditional block).

-Peff