Re: [PATCH] travis-ci: build Git during the 'script' phase
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Jan 8, 2018, 22:38 UTC
- Message-ID
- <5DE3FA05-2347-4BE7-8A1A-A6E5FEEC7C2B@gmail.com>
- In-Reply-To
- <xmqqvagc6m42.fsf@gitster.mtv.corp.google.com>
Show 18 quoted lines
> On 08 Jan 2018, at 23:07, Junio C Hamano <gitster@pobox.com> wrote: > > SZEDER Gábor <szeder.dev@gmail.com> writes: > >> The reason why Travis CI does it this way and why it's a better >> approach than ours lies in how unsuccessful build jobs are >> categorized. ... >> ... >> This makes it easier, both for humans looking at the Travis CI web >> interface and for automated tools querying the Travis CI API,... >> ... >> A verbose commit message for such a change... but I don't know why we >> started with building Git in the 'before_script' phase. > > Thanks for writing it up clearly. TBH, I didn't even realize that > there were meaningful distinctions between the two cases after > seeing that sometimes our tests were failing and sometimes erroring > ;-)
I understand the reasons for the proposed patch. However, I did this intentionally back then. Here is my reason:
If `make` is successful, then I am not interested in its output. Look at this run: https://travis-ci.org/szeder/git/jobs/324271623
You have to scroll down 1,406 lines to get to the test result output (this is usually the interesting part).
If this is a valid argument for you, would it be an option to pipe the verbose `make` output to a file and only print it in case of error (we do something similar for the tests already).
- Lars