Re: [PATCH v4 03/13] commit-graph: create git-commit-graph builtin

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2018, 21:51 UTC
Message-ID: <xmqqvaer1ga1.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <1519066406-81663-4-git-send-email-dstolee@microsoft.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 6 quoted lines

> +int cmd_commit_graph(int argc, const char **argv, const char *prefix)
> +{
> +	static struct option builtin_commit_graph_options[] = {
> +		{ OPTION_STRING, 'p', "object-dir", &opts.obj_dir,
> +			N_("dir"),
> +			N_("The object directory to store the graph") },

I have a suspicion that this was modeled after some other built-in that has a similar issue (perhaps written long time ago), but isn't OPT_STRING() sufficient to define this element these days?

Or am I missing something?

Why squat on short-and-sweet "-p"? For that matter, since this is not expected to be end-user facing command anyway, I suspect that we do not want to allocate a single letter option from day one, which paints ourselves into a corner from where we cannot escape.