Re: [PATCH v3 03/14] commit-graph: create git-commit-graph builtin

From: Derrick Stolee <stolee@gmail.com>
Date: Feb 8, 2018, 21:36 UTC
Message-ID: <9c473af6-fc67-5612-07dd-54b2a6e24ff0@gmail.com>
In-Reply-To: <xmqqzi4jp3y5.fsf@gitster-ct.c.googlers.com>

On 2/8/2018 4:27 PM, Junio C Hamano wrote:

Show 11 quoted lines

> Derrick Stolee <stolee@gmail.com> writes:
>
>> Teach git the 'commit-graph' builtin that will be used for writing and
>> reading packed graph files. The current implementation is mostly
>> empty, except for a '--pack-dir' option.
> Why do we want to use "pack" dir, when this is specifically designed
> not tied to packfile?  .git/objects/pack/ certainly is a possibility
> in the sense that anywhere inside .git/objects/ would make sense,
> but using the "pack" dir smells like signalling a wrong message to
> users.
>

I wanted to have the smallest footprint as possible in the objects directory, and the .git/objects directory currently only holds folders.

I suppose this feature, along with the multi-pack-index (MIDX), extends the concept of the pack directory to be a "compressed data" directory, but keeps the "pack" name to be compatible with earlier versions.

Another option is to create a .git/objects/graph directory instead, but then we need to worry about that directory being present.

Thanks, -Stolee