Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2018, 16:22 UTC
Message-ID: <xmqqva78cal9.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180914151710.3261463b@xenom-bubu>

Shulhan <m.shulhan@gmail.com> writes:

Show 8 quoted lines

> if source is run successfully before I know the patch was correct, as
> the "t/README" said,
>
>   Running Tests
>   -------------
>
>   The easiest way to run tests is to say "make".  This runs all
>   the tests.

t/README says that it is sufficient to run "make" to perform tests, but that implicitly assumes that the people who are reading it are now in the t/ directory.

We probably want to clarify the language there, perhaps like so?

Thanks.

 t/README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/README b/t/README
index 8373a27fea..f95624959f 100644
--- a/t/README
+++ b/t/README
@@ -14,8 +14,8 @@ describes how your test scripts should be organized.
 Running Tests
 -------------
 
-The easiest way to run tests is to say "make".  This runs all
-the tests.
+The easiest way to run tests is to say "make" in this directory (or
+"make test" from the top-level).  This runs all the tests.
 
     *** t0000-basic.sh ***
     ok 1 - .git/objects should be empty after git init in an empty repo.