Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

From: Shulhan <m.shulhan@gmail.com>
Date: Sep 14, 2018, 08:17 UTC
Message-ID: <20180914151710.3261463b@xenom-bubu>
In-Reply-To: <xmqqpnxhdq0z.fsf@gitster-ct.c.googlers.com>

On Thu, 13 Sep 2018 14:51:56 -0700 Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

> Shulhan <m.shulhan@gmail.com> writes:
> 
> > When adding new remote name with empty string, git will print the
> > following error message,
> >
> >   fatal: '' is not a valid remote name\n
> >
> > But when removing remote name with empty string as input, git shows
> > the empty string without quote,
> >
> >   fatal: No such remote: \n
> >
> > To make these error messages consistent, quote the name of the
> > remote that we tried and failed to find.
> >
> > Signed-off-by: Shulhan <m.shulhan@gmail.com>
> > Reviewed-by: Junio C Hamano <gitster@pobox.com>
> > ---
> >  builtin/remote.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)  
> 
> Have you run "make test" with this change?  
> 
> I expect at least 5505.10 to fail without adjustment.

I am really sorry about that. I am pretty sure, I run "make" to check if source is run successfully before I know the patch was correct, as the "t/README" said,

  Running Tests
  -------------

  The easiest way to run tests is to say "make".  This runs all
  the tests.

I will look into it later, if there is an error on test, I will send another version of patch.

-- 
{ "github":"github.com/shuLhan", "site":"kilabit.info" }