git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 13, 2018, 21:51 UTC
Message-ID
<xmqqpnxhdq0z.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180913131833.32722-1-m.shulhan@gmail.com>
Shulhan <m.shulhan@gmail.com> writes:
Show 18 quoted lines
> When adding new remote name with empty string, git will print the
> following error message,
>
>   fatal: '' is not a valid remote name\n
>
> But when removing remote name with empty string as input, git shows the
> empty string without quote,
>
>   fatal: No such remote: \n
>
> To make these error messages consistent, quote the name of the remote
> that we tried and failed to find.
>
> Signed-off-by: Shulhan <m.shulhan@gmail.com>
> Reviewed-by: Junio C Hamano <gitster@pobox.com>
> ---
>  builtin/remote.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
Have you run "make test" with this change?  
I expect at least 5505.10 to fail without adjustment.
Previous: ShulhanNext: Junio C Hamano
Message 2 of 5 in “builtin/remote: quote remote name on error to display empty name”
  1. builtin/remote: quote remote name on error to display empty nameShulhan, Sep 13, 2018
  2. Junio C HamanoSep 13, 2018
  3. Junio C HamanoSep 13, 2018
  4. ShulhanSep 14, 2018
  5. Junio C HamanoSep 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.