Re: [PATCH 3/3] sha1-file: change alternate "error:" message to "warning:"

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 5, 2018, 03:37 UTC
Message-ID: <xmqqva48d4o9.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181204132716.19208-4-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 7 quoted lines

> Change the "error" message emitted by alt_odb_usable() to be a
> "warning" instead. As noted in commits leading up to this one this has
> never impacted the exit code ever since the check was initially added
> in 26125f6b9b ("detect broken alternates.", 2006-02-22).
>
> It's confusing to emit an "error" when e.g. "git fsck" will exit with
> 0, so let's emit a "warning:" instead.

OK, that sounds sensible. An alternative that may be more sensible is to actually diagnose this as an error, but the purpose of this message is to help users diagnose a possible misconfiguration and keeping the repository "working" with the remaining set of object stores by leaving it as a mere warning, like this patch does, is probably a better approach.