Re: How de-duplicate similar repositories with alternates
- From
Jeff King <peff@peff.net>
- Date
- Dec 4, 2018, 06:59 UTC
- Message-ID
- <20181204065930.GA11010@sigill.intra.peff.net>
- In-Reply-To
- <87zhtsx73l.fsf@evledraar.gmail.com>
On Thu, Nov 29, 2018 at 03:59:26PM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 6 quoted lines
> This is the thing I was wrong about, in retrospect probably because I'd > been putting PATH_TO_REPO in objects/info/alternates, but we actually > need PATH_TO_REPO/objects, and "git gc" won't warn about this (or "git > fsck"). Probably a good idea to patch that at some point, i.e. whine > about paths in alternates that don't have objects, or at the very least > those that don't exist. #leftoverbits
We do complain about missing directories; see alt_odb_usable(). Pointing to a real directory that doesn't happen to contain any objects is harder. If there are no loose objects, there might not be any hashed object directories. For a "real" object database, there should always be a "pack/" directory. But technically the object storage directory does not even need to have that; it can just be a directory full of loose objects that happens not to have any at this moment.
That said, I suspect if we issued a warning for "woah, it looks like this doesn't have any objects in it, nor does it even have a pack directory" that nobody would complain.
-Peff