Re: [PATCH v2] sha1-file: test the error behavior of alt_odb_usable()
- From
Jeff King <peff@peff.net>
- Date
- Apr 9, 2019, 14:14 UTC
- Message-ID
- <20190409141445.GA7371@sigill.intra.peff.net>
- In-Reply-To
- <xmqq5zrn7bua.fsf@gitster-ct.c.googlers.com>
On Tue, Apr 09, 2019 at 06:43:41PM +0900, Junio C Hamano wrote:
Show 7 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > > > I'll leave it up to you if you want to queue just the test patch or drop > > As I said in a separate message, I think it is good to make sure > that fsck does not crash. I do not think it is good to grep in its > output.
FWIW, that approach (and your rationale below) makes a lot of sense to me for this case.
-Peff