Re: [PATCH 1/7] remote-testgit: move it into the support directory for t5801

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2019, 07:08 UTC
Message-ID: <xmqqv9zfsq31.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <81c08b178be6329d51586fa9d615063d3c6f9625.1555070430.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 10 quoted lines

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The `git-remote-testgit` script is really only used in
> `t5801-remote-helpers.sh`. It does not even contain any `@@<MAGIC>@@`
> placeholders that would need to be interpolated via `make
> git-remote-testgit`.
>
> Let's just move it to a new home, decluttering the top-level directory
> and clarifying that this is just a test helper, not an official Git
> command that we would want to ever support.

Makes sense.

Show 6 quoted lines

> @@ -657,8 +656,6 @@ SCRIPT_PERL += git-svn.perl
>  
>  SCRIPT_PYTHON += git-p4.py
>  
> -NO_INSTALL += git-remote-testgit
> -

The line lost here was the last one that updated the value of NO_INSTALL, so we should be able to lose all the mentions of the make variable now.

Show 10 quoted lines

> diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> index aaaa722cca..d04f8007e0 100755
> --- a/t/t5801-remote-helpers.sh
> +++ b/t/t5801-remote-helpers.sh
> @@ -8,6 +8,8 @@ test_description='Test remote-helper import and export commands'
>  . ./test-lib.sh
>  . "$TEST_DIRECTORY"/lib-gpg.sh
>  
> +PATH="$TEST_DIRECTORY/t5801:$PATH"
> +

I guess this makes much more sense than having it next to other test helpers, as t5801 is the home for the remote-helper tests.

Thanks, will queue.