Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

From: Jeff King <peff@peff.net>
Date: Apr 18, 2019, 16:01 UTC
Message-ID: <20190418160115.GA8054@sigill.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.1904181505520.46@tvgsbejvaqbjf.bet>

On Thu, Apr 18, 2019 at 03:06:56PM +0200, Johannes Schindelin wrote:

Show 13 quoted lines

> > What about command-line options that influence the outcome? It sounds
> > like this is the same problem we have in lots of other places (like say,
> > compiler flags being updated), that we solve by generating the proposed
> > file output unconditionally and comparing it to what's on disk.  E.g.,
> > see the way GIT-CFLAGS or GIT-BUILD-OPTIONS is generated.
> 
> *Sigh*
> 
> I really did not want to do that because I thought it would be tedious and
> more complicated and result in a longer patch.
> 
> Well, don't you know. The patch is actually *a lot* shorter now. So much
> so that range-diff thinks it is a different commit ;-)

:) Great. I looked at the result in your v2 and it looks good to me.

-Peff