Re: [PATCH 7/7] Turn `git serve` into a test helper
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 18, 2019, 12:17 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1904181416250.46@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqa7grqsbt.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Mon, 15 Apr 2019, Junio C Hamano wrote:
Show 24 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > From: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > The `git serve` built-in was introduced in ed10cb952d31 (serve: > > introduce git-serve, 2018-03-15) as a backend to serve Git protocol v2, > > probably originally intended to be spawned by `git upload-pack`. > > > > However, in the version that the protocol v2 patches made it into core > > Git, `git upload-pack` calls the `serve()` function directly instead of > > spawning `git serve`; The only reason in life for `git serve` to survive > > as a built-in command is to provide a way to test the protocol v2 > > functionality. > > > > Meaning that it does not even have to be a built-in that is installed > > with end-user facing Git installations, but it can be a test helper > > instead. > > > > Let's make it so. > > > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > I've excluded this step from tonight's pushout, as I would want to
^^^^^^^
Would you be surprised that I first read this as "pu shout"?
Show 9 quoted lines
> hear from the people on the other side who have (once) thought that > this was an addition we would want to have, before we remove/demote > it. > > I do not personally think, as the design of v2 stands, a standalone > "serve" server that "can serve anything as long as it goes over > protocol v2" makes much sense, but perhaps those who have been doing > the v2 work may have different ideas, in which case let's hear what > their plans are.
As this has been resolved in the meantime, I'll just leave it as-is.
Ciao, Dscho