git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 8, 2019, 19:23 UTC
Message-ID
<xmqqv9wcxre3.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<1f0f4fe6fbf0e7a7eea1f3d49db183c70693a895.1562231679.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> A `+` is not a valid part of a filename with Windows file systems (it is
> reserved because the `+` operator meant file concatenation back in the
> DOS days).

The title of the cover letter had "windows" in it, so calling '+' illegal was OK, but this patch does not.

I'd rather not to take this patch, because "generate in the target with plus appended, make sure it succeeds, and then rename it to the real target" is quite an established pattern not limited to the Documentation/ directory of this project, if your tooling has been supporting it and can continue to do so (which was the impression I got from the cover letter). Even the top-level .gitignore file knows about it, so does the top-level Makefile and it uses the same pattern.

Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin
Message 3 of 8 in “windows: avoid illegal filenames during a build”
  1. 0/1 windows: avoid illegal filenames during a buildJohannes Schindelin via GitGitGadget, Jul 4, 2019
  2. 1/1 Avoid illegal filenames when building Documentation on NTFSJohannes Schindelin via GitGitGadget, Jul 4, 2019
  3. Junio C HamanoJul 8, 2019
  4. Johannes SchindelinJul 9, 2019
  5. Junio C HamanoJul 9, 2019
  6. Johannes SchindelinJul 10, 2019
  7. Junio C HamanoJul 10, 2019
  8. Johannes SchindelinJul 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.