git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 10, 2019, 20:35 UTC
Message-ID
<nycvar.QRO.7.76.6.1907102137060.46@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqqef2xu4oz.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Wed, 10 Jul 2019, Junio C Hamano wrote:
Show 7 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
> >> In addition, your `+` scheme will break on Windows once it uses `git.exe`
> >> or any other non-MSYS2 helper...
> >
> > I am not sure what you mean here.  Is your git.exe disabled not to
> > be able to do this: "git.exe add hello+kitty.txt"?
It's not that. The `+` is not allowed on Windows in general.

Mind you, I just read up on the details (see e.g. https://en.wikipedia.org/wiki/Filename#Comparison_of_filename_limitations) and it looks as if NTFS actually _allows_ this. Even VFAT allows it, but FAT32 does not.

So I guess I retract my objections, as there are probably smarter ideas than building Git for Windows on a FAT32 drive.

For aesthetical reasons, I still do not like the convention to append a `+` when appending `.new` would make things clearer, but this is not a hill I am prepared to die on.

Ciao, Dscho

Previous: Junio C Hamano
Message 8 of 8 in “windows: avoid illegal filenames during a build”
  1. 0/1 windows: avoid illegal filenames during a buildJohannes Schindelin via GitGitGadget, Jul 4, 2019
  2. 1/1 Avoid illegal filenames when building Documentation on NTFSJohannes Schindelin via GitGitGadget, Jul 4, 2019
  3. Junio C HamanoJul 8, 2019
  4. Johannes SchindelinJul 9, 2019
  5. Junio C HamanoJul 9, 2019
  6. Johannes SchindelinJul 10, 2019
  7. Junio C HamanoJul 10, 2019
  8. Johannes SchindelinJul 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.