Re: [PATCH 1/1] Avoid illegal filenames when building Documentation on NTFS

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 9, 2019, 13:27 UTC
Message-ID: <nycvar.QRO.7.76.6.1907091524460.5700@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqv9wcxre3.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Mon, 8 Jul 2019, Junio C Hamano wrote:

Show 17 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > A `+` is not a valid part of a filename with Windows file systems (it is
> > reserved because the `+` operator meant file concatenation back in the
> > DOS days).
>
> I'd rather not to take this patch, because "generate in the target
> with plus appended, make sure it succeeds, and then rename it to the
> real target" is quite an established pattern not limited to the
> Documentation/ directory of this project, if your tooling has been
> supporting it and can continue to do so (which was the impression I
> got from the cover letter).  Even the top-level .gitignore file
> knows about it, so does the top-level Makefile and it uses the same
> pattern.

Using `.lock` is actually an even more established pattern. (I used `.new` because the intention is not to lock files, but I would be prepared to change the patch to that end.)

In addition, your `+` scheme will break on Windows once it uses `git.exe` or any other non-MSYS2 helper, so it is not future-proof, no matter how established you claim it to be.

Ciao, Dscho