Show 23 quoted lines
> So these patches are punting on the greater question of why we want to
> parse so early, and are not making anything worse. AFAICT, "clone
> --filter=sparse:oid" has never worked (even though our tests did cover
> the underlying rev-list and pack-objects code paths).
> ...
> TBH, I'm not sure why the original is so eager to parse early. I guess
> it allows:
>
> - a dual use of the options parser; we can use it both to sanity-check
> the options before sending them to a server, and to actually use the
> filter ourselves.
>
> - earlier detection maybe gives us a cleaner error path (e.g.,
> rev-list can do its own error handling). But I'd think doing it when
> we actually initialize the filter would be enough.
>
> I.e., if we want to go all the way, I think this two-patch series could
> basically be replaced with something like the (totally untested)
> approach below, which just pushes the parsing closer to the
> point-of-use.
>
> Adding Jeff Hostetler to the cc, in case he recalls any reason not to
> use that approach.
Junio C Hamano <gitster@pobox.com>