Re: [PATCH 2/3] list-objects-filter: delay parsing of sparse oid
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> It's a good idea to parse as much as we can in step 1, in order to catch
> problems early (e.g., a blob size limit that isn't a number). But one
> thing we _shouldn't_ do is resolve any oids at that step (e.g., for
> sparse-file contents specified by oid). In the case of a fetch, the oid
> has to be resolved on the remote side.
> ...
> We can fix both by moving the oid resolution into the sparse-oid init
> function. At that point we know we have a repository (because we're
> about to traverse), and handling the error there fixes the segfault.
Makes sense. Thanks for a clean solution to a messy problem.