Re: [PATCH v3 1/2] list-objects-filter: only parse sparse OID when 'have_git_dir'
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Sep 9, 2019, 19:49 UTC
- Message-ID
- <76c1470c-929e-4116-c0ba-9514b836fb24@jeffhostetler.com>
- In-Reply-To
- <xmqqv9u1l7ha.fsf@gitster-ct.c.googlers.com>
On 9/9/2019 1:12 PM, Junio C Hamano wrote:
Show 12 quoted lines
> Jeff Hostetler <git@jeffhostetler.com> writes: > >> It would be nice if we could continue to let parse_list_objects_filter() >> do the syntax checking -- that is, we can still check that we received a >> ulong in "blob:limit:<nr>" and that "sparse:oid:<oid>" looks like a hex >> value, for example. Just save the actual <oid> lookup to the higher >> layer, if and when that makes sense. > > Hmmm, am I misremembering things or did I hear somebody mention in > this thread that people give "sparse:oid:master" (not blob object > name in hex, but a refname) and expect the other side to resolve it? >
You're right. I misspoke. I was thinking about the hex OID case and forgetting about the <rev>:<path> form.
Jeff