git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 3, 2019, 00:41 UTC
Message-ID
<xmqqv9t6d5iy.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<xmqq4l0qewu5.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>>
>> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
>> and `b/` in the diff headers.
>
> If so, passing src/dst prefix as command line option is a much
> better solution, I think.  diff.noprefix may not stay to be (or it
> may already not to be) the only thing how the prefix gets chosen.

That is, "--src-prefix=a/ --dst-prefix=b/", so that configuration variables yet to be invented for setting prefixes different from a/ and b/ can also be overridden, not just diff.noprefix (ancient Git used l/ and k/ as src and dst prefix, IIRC).

Previous: Junio C HamanoNext: Johannes Schindelin via GitGitGadget
Message 8 of 11 in “Avoid segmentation fault in git range-diff when diff.noprefix=true”
  1. 0/1 Avoid segmentation fault in git range-diff when diff.noprefix=trueJohannes Schindelin via GitGitGadget, Oct 2, 2019
  2. 1/1 range-diff: internally force `diff.noprefix=false`Johannes Schindelin via GitGitGadget, Oct 2, 2019
  3. Eric SunshineOct 2, 2019
  4. Michal SuchánekOct 2, 2019
  5. Junio C HamanoOct 2, 2019
  6. Johannes SchindelinOct 2, 2019
  7. Junio C HamanoOct 3, 2019
  8. Junio C HamanoOct 3, 2019
  9. 0/1 Avoid segmentation fault in git range-diff when diff.noprefix=trueJohannes Schindelin via GitGitGadget, Oct 2, 2019
  10. 1/1 range-diff: internally force `diff.noprefix=true`Johannes Schindelin via GitGitGadget, Oct 2, 2019
  11. Junio C HamanoOct 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.