Re: [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 3, 2019, 02:11 UTC
- Message-ID
- <xmqq1rvud1dm.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <9993a607beaafc66f72e1be3f158074cd121b4bb.1570050645.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 12 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > When parsing the diffs, `range-diff` expects to see the prefixes `a/` > and `b/` in the diff headers. > > These prefixes can be forced off via the config setting > `diff.noprefix=true`. As `range-diff` is not prepared for that > situation, this will cause a segmentation fault. > > Let's avoid that by passing the `--no-prefix` option to the `git log` > process that generates the diffs that `range-diff` wants to parse. > And of course expect the output to have no prefixes, then.
Looks good. Thanks.