git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] range-diff: internally force `diff.noprefix=true`

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 3, 2019, 02:11 UTC
Message-ID
<xmqq1rvud1dm.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<9993a607beaafc66f72e1be3f158074cd121b4bb.1570050645.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 12 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
> and `b/` in the diff headers.
>
> These prefixes can be forced off via the config setting
> `diff.noprefix=true`. As `range-diff` is not prepared for that
> situation, this will cause a segmentation fault.
>
> Let's avoid that by passing the `--no-prefix` option to the `git log`
> process that generates the diffs that `range-diff` wants to parse.
> And of course expect the output to have no prefixes, then.
Looks good.  Thanks.
Previous: Johannes Schindelin via GitGitGadget
Message 11 of 11 in “Avoid segmentation fault in git range-diff when diff.noprefix=true”
  1. 0/1 Avoid segmentation fault in git range-diff when diff.noprefix=trueJohannes Schindelin via GitGitGadget, Oct 2, 2019
  2. 1/1 range-diff: internally force `diff.noprefix=false`Johannes Schindelin via GitGitGadget, Oct 2, 2019
  3. Eric SunshineOct 2, 2019
  4. Michal SuchánekOct 2, 2019
  5. Junio C HamanoOct 2, 2019
  6. Johannes SchindelinOct 2, 2019
  7. Junio C HamanoOct 3, 2019
  8. Junio C HamanoOct 3, 2019
  9. 0/1 Avoid segmentation fault in git range-diff when diff.noprefix=trueJohannes Schindelin via GitGitGadget, Oct 2, 2019
  10. 1/1 range-diff: internally force `diff.noprefix=true`Johannes Schindelin via GitGitGadget, Oct 2, 2019
  11. Junio C HamanoOct 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.