git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] range-diff: internally force `diff.noprefix=false`

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Oct 2, 2019, 18:34 UTC
Message-ID
<CAPig+cS1XHLC3Q_Ntq=-Ck8WzRR7FL1qwQuCfUPVFSTkEKK+LQ@mail.gmail.com>
In-Reply-To
<1f84f92846bc14d21aa7339c8baa0f9bb710b17d.1570039511.git.gitgitgadget@gmail.com>

On Wed, Oct 2, 2019 at 2:05 PM Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 8 quoted lines
> When parsing the diffs, `range-diff` expects to see the prefixes `a/`
> and `b/` in the diff headers.
>
> These prefixes can be forced off via the config setting
> `diff.noprefix=true`. As `range-diff` is not prepared for that
> situation, this will cause a segmentation fault.
>
> Let's avoid that by forcing `diff.noprefix=false` just for that all to
s/all/call/
> `git log` that generates the diffs that `range-diff` wants to parse.
>
> Noticed-by: Michal Suchánek <msuchanek@suse.de>
s/Noticed/Reported/ perhaps?
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Previous: Johannes Schindelin via GitGitGadgetNext: Michal Suchánek
Message 3 of 11 in “Avoid segmentation fault in git range-diff when diff.noprefix=true”
  1. 0/1 Avoid segmentation fault in git range-diff when diff.noprefix=trueJohannes Schindelin via GitGitGadget, Oct 2, 2019
  2. 1/1 range-diff: internally force `diff.noprefix=false`Johannes Schindelin via GitGitGadget, Oct 2, 2019
  3. Eric SunshineOct 2, 2019
  4. Michal SuchánekOct 2, 2019
  5. Junio C HamanoOct 2, 2019
  6. Johannes SchindelinOct 2, 2019
  7. Junio C HamanoOct 3, 2019
  8. Junio C HamanoOct 3, 2019
  9. 0/1 Avoid segmentation fault in git range-diff when diff.noprefix=trueJohannes Schindelin via GitGitGadget, Oct 2, 2019
  10. 1/1 range-diff: internally force `diff.noprefix=true`Johannes Schindelin via GitGitGadget, Oct 2, 2019
  11. Junio C HamanoOct 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.