Re: [PATCH] rebase --autosquash: fix a potential segfault

From: Junio C Hamano <gitster@pobox.com>
Date: May 5, 2020, 20:30 UTC
Message-ID: <xmqqv9la9lbn.fsf@gitster.c.googlers.com>
In-Reply-To: <20200504220916.GF45250@syl.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 13 quoted lines

>> > +				/*
>> > +				 * i2 refers to a fixup commit in the middle of
>> > +				 * a fixup chain
>> > +				 */
>> > +				next[i] = next[i2];
>> > +				next[i2] = i;
>> > +				continue;
>> > +			}
>>
>> I do have one question, though. What happens if we add a second
>> fixup-of-a-fixup?
>
> Thanks for asking this question, I was a little curious about it, too.

Interesting that three people looked at the same patch and asked the same question in different ways ;-)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.