Re: [PATCH] rebase --autosquash: fix a potential segfault

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 6, 2020, 21:35 UTC
Message-ID: <nycvar.QRO.7.76.6.2005062334170.56@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqv9la9lbn.fsf@gitster.c.googlers.com>

Hi Junio,

On Tue, 5 May 2020, Junio C Hamano wrote:

Show 18 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
> >> > +				/*
> >> > +				 * i2 refers to a fixup commit in the middle of
> >> > +				 * a fixup chain
> >> > +				 */
> >> > +				next[i] = next[i2];
> >> > +				next[i2] = i;
> >> > +				continue;
> >> > +			}
> >>
> >> I do have one question, though. What happens if we add a second
> >> fixup-of-a-fixup?
> >
> > Thanks for asking this question, I was a little curious about it, too.
>
> Interesting that three people looked at the same patch and asked the
> same question in different ways ;-)

Indeed!

I am very grateful, as I had missed that, and it helped me figure out a better way to do it, and v2 looks a lot nicer, too.

Ciao, Dscho