Re: [PATCH] rebase --autosquash: fix a potential segfault

From: Jeff King <peff@peff.net>
Date: May 7, 2020, 19:17 UTC
Message-ID: <20200507191714.GA25306@coredump.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.2005062334170.56@tvgsbejvaqbjf.bet>

On Wed, May 06, 2020 at 11:35:48PM +0200, Johannes Schindelin wrote:

Show 17 quoted lines

> > >> > +				next[i] = next[i2];
> > >> > +				next[i2] = i;
> > >> > +				continue;
> > >> > +			}
> > >>
> > >> I do have one question, though. What happens if we add a second
> > >> fixup-of-a-fixup?
> > >
> > > Thanks for asking this question, I was a little curious about it, too.
> >
> > Interesting that three people looked at the same patch and asked the
> > same question in different ways ;-)
> 
> Indeed!
> 
> I am very grateful, as I had missed that, and it helped me figure out a
> better way to do it, and v2 looks a lot nicer, too.

OK, so your v2 addresses that. Does that mean it was broken in v1? If so, then why didn't my test reveal it?

I'm not really doubting that your v2 works so much as trying to un-confuse myself about the whole situation (which in turn might lead to a more intelligent review).

-Peff